fix/tekton: updated currency generation#741
Closed
CagriYonca wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
fix/currency_version
branch
from
8623285 to
05d9675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of aiohttp package is not supported for Python 3.8. Since the currency generation works for all python versions except 3.8 and we sort pipeline runs based on creation time, it was creating a currency record for aiohttp.
In this PR, I've changed the code to sort pipeline runs based on task numbers (so depending on python versions)