fix(ui-source-code-editor): Scroll bug in SourceCodeEditor#2493
Merged
git-nandor merged 1 commit intomasterfrom Apr 7, 2026
Merged
fix(ui-source-code-editor): Scroll bug in SourceCodeEditor#2493git-nandor merged 1 commit intomasterfrom
git-nandor merged 1 commit intomasterfrom
Conversation
|
matyasf
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4948
Summary
Preserve scroll position in controlled mode.
When SourceCodeEditor is in controlled mode (value prop), refreshEditorValue()
replaces the entire document which triggers CodeMirror's view update cycle.
This causes the scroll position to reset to the top even though the cursor
position is correctly restored.
Fix
Saving the scroll position before the content update and restoring
it after CodeMirror has updated the DOM using requestAnimationFrame.
Test plan
<div data-cid="SourceCodeEditor" ...>element andset its
heightfromautoto80px./** This is an examplesection inside the editor.Co-Authored-By: 🤖 Claude