refactor(many): extract raw svgs for cross-package use#2543
Open
HouseOfHawks wants to merge 1 commit into
Open
refactor(many): extract raw svgs for cross-package use#2543HouseOfHawks wants to merge 1 commit into
HouseOfHawks wants to merge 1 commit into
Conversation
|
|
|
HouseOfHawks
force-pushed
the
TASTY-1731
branch
3 times, most recently
from
68f4ad5 to
c66c76d
Compare
Visual regression report✅ No changes.
Baselines come from the |
Collaborator
|
Can you please add a postfix to the new icons? e.g. |
extracted raw svgs into a new ui-icons-svg package and added as a dependency in ui-icons feat(ui-scripts,ui-icons,ui-icons-svg): added parchment assets added parchment icons, vectors and graphics retooled script bundling to support parchment asset categories extended demo app to conditionally render all icons by org extended demo app to conditionally render parchment icons by type refactor(ui-icons-svg): icons cleanup cleaned up now unused directory refactor(ui-scripts): typescript fix fix(github actions): pin chromaui/action to v11 ci(github actions): removed debugging change refactor(ui-scripts): rebase and add suffix Handled a complex rebase and added a ParchIcon suffix to Parchment Icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ui-icons-svgpackage, free of framework dependencies, for use in other icon-generating packages,ui-icons-svg/svg/Parchmentfor allGraphics,IconsandVectorsused in Parchment, Digitary, Scribbles and Quottly applications,ui-iconswhile making new Parchment icons available in this React package (both legacy and beta), and__docs__app so that consumers can now filter icons by organization type and asset type when viewing Parchment assets (demo below)Tech-Spec Outlining the Justification For This Work
Demo:
Screen.Recording.2026-05-06.at.8.46.53.AM.mov
Next iterations (ongoing work):
Currently there is significant asset overlap. Design teams will need to work through both asset libraries and unify that overlap (ie, InstUI's
x.svgand Parchment'sclose.svg). Parchment application developers will need access to this full set of assets initially as teams begin implementing InstUI, but as re-design work becomes available those teams will be pointed to the InstUI icons where applicable. In other cases where assets are Parchment-specific or there is no InstUI counterpart, those Parchment assets will remain.