Rework documentation#2550
Conversation
5d2192b to
add5121
Compare
Visual regression report✅ No changes.
Baselines come from the |
|
408073b to
a8a412c
Compare
a8a412c to
d128181
Compare
hajnaldo
left a comment
There was a problem hiding this comment.
Shared Tokens:
Documentation: It would be nice to mention explicitly that devs should use these tokens when they are tasked to build custom solutions (bc if they do so, the theming will work on their custom-built stuff too).
Token list:
- Elevation-related tokens:
Would it be possible to reflect what values belong to certain elevation styles, such as ordering them into groups according to how it is shown in the json:
"elevation1": { "value": [ { "x": "{semantic.dropShadow.x.elevation1.dropshadow1}", "y": "{semantic.dropShadow.y.elevation1.dropshadow1}", "blur": "{semantic.dropShadow.blur.elevation1.dropshadow1}", "spread": "{semantic.dropShadow.spread.elevation1.dropshadow1}", "color": "{semantic.color.dropShadow.shadowColor1}", "type": "dropShadow" }, { "x": "{semantic.dropShadow.x.elevation1.dropshadow2}", "y": "{semantic.dropShadow.y.elevation1.dropshadow2}", "blur": "{semantic.dropShadow.blur.elevation1.dropshadow2}", "spread": "{semantic.dropShadow.spread.elevation1.dropshadow2}", "color": "{semantic.color.dropShadow.shadowColor2}", "type": "dropShadow" } ]
Theme Overrides:
Although it is technically possible to override primitives and it may even be useful, we don't want to encourage it upfront. Would it be possible not to proactively show this option in the docu?
d128181 to
a65c973
Compare
1959e8e to
59b7ab8
Compare
59b7ab8 to
ba6ede5
Compare
Thanks for the suggestions, I’ve updated the Shared Tokens page. |
INSTUI-4997
Summary
Co-Authored-By: 🤖 Claude