fix(ui-select): fix screen reader labels on multiple select#2616
Open
git-nandor wants to merge 1 commit into
Open
fix(ui-select): fix screen reader labels on multiple select#2616git-nandor wants to merge 1 commit into
git-nandor wants to merge 1 commit into
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
git-nandor
requested review from
HerrTopi,
ToMESSKa,
balzss,
joyenjoyer and
matyasf
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5076
Summary
When a Select renders selected options as dismissible Tag pills their "Remove …" labels always announced.
Changes
The combobox now gets an aria-labelledby pointing at a dedicated hidden element that mirrors only the field label.
Since aria-labelledby overrides the wrapping- name computation, the pills are excluded from the combobox name — while each pill keeps its own "Remove …" name, so it is still announced when focused directly.
Test plan
Uses the "Highlighting and selecting options" multiple-select example on the Select v2 docs page.
Co-Authored-By: 🤖 Claude