fix(pkg-utils): make named exports detectable by cjs-module-lexer#2619
Open
balzss wants to merge 1 commit into
Open
fix(pkg-utils): make named exports detectable by cjs-module-lexer#2619balzss wants to merge 1 commit into
balzss wants to merge 1 commit into
Conversation
Hoist the inline `require()` calls out of the `module.exports` object literal. Inline requires in the literal defeat cjs-module-lexer's static analysis, so ESM consumers doing `import * as pkgUtils from '@instructure/pkg-utils'` only saw `getPackages` and got `undefined` for the rest — breaking `ui-scripts` publish/bump/tag/deprecate with "pkgUtils.getPackageJSON is not a function" after ui-scripts was converted to ESM/TypeScript. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Visual regression report✅ No changes.
Baselines come from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require()calls out ofpkg-utils'smodule.exportsobject literal so all named exports are statically detectable bycjs-module-lexer.ui-scripts(ESM/TS since refactor(many): convert ui-scripts to TypeScript and add tests #2578) sawundefinedforgetPackageJSON/getPackage/getChangedPackagesviaimport * as pkgUtils, breaking publish/bump/tag/deprecate.Test Plan
Fixes INSTUI-5086
🤖 Generated with Claude Code