Add support for if else expressions - #303
Open
jgardn3r wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
fourls
requested changes
Aug 6, 2026
fourls
left a comment
fourls
left a comment
Collaborator
There was a problem hiding this comment.
I have played around with it a bit and I'm mostly happy with the rule as it is. Let's add some more complex examples in the tests, especially with anonymous methods and with nesting in the else block, and I think we should have most of the edge cases.
Also there is a commit message typo: Convert get_operator_precedence to a trait routine
jgardn3r
force-pushed
the
if-else-expression
branch
from
August 10, 2026 03:49
75bc30a to
ba57f10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #273.
There are some commits from the compound operator PR that will disappear after it is merged.
Adding a feature like this requires changes to contexts, rules, and the overall understanding of the roles
ifandelseplay in the context of a line.