fix(resource_github_organization_custom_properties): support bool default values

[secustor]

This is a minimal fix for users of default values and is intentionally tries not to reach the scope of #3234

Closes: #3580

Resolves infinite drift if when using resource_github_organization_custom_properties of value_type true_false and default_value.

Infinite terraform plan:

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_organization_custom_properties.stedisentry_enabled will be updated in-place
  ~ resource "github_organization_custom_properties" "foo" {
      + default_value      = "true"
        id                 = "foo"
        # (6 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

---

Before the change?

customProperty.DefaultValueString() will return "", nill because of https://github.com/google/go-github/blob/a3951f514384b06cc428f394672020c14f7efd84/github/orgs_properties.go#L59

resource "github_organization_custom_properties" "foo" {
  property_name = "foo"
  value_type    = "true_false"
  required      = true

  // currently there is an infinite drift setting creating an addition on each plan 
  default_value = "true" // `true` has the same behavior 
}

This forces following workaround

resource "github_organization_custom_properties" "foo" {
  property_name = "foo"
  value_type    = "true_false"
  required      = true

  default_value = "true"

  lifecycle {
    ignore_changes = [default_value]
  }
}

After the change?

With this instead customProperty.DefaultValueBool() is called and with that the return value is true, nill which will then correctly set in the state

Pull request checklist

• Schema migrations have been created if needed (example)
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.

---

_{🤖 This is an automated message.}

[deiga]

Please mark clearly which issue this is going to resolve!

[secustor]

Resolves infinite drift if when using resource_github_organization_custom_properties of value_type true_false and default_value.

I have been under the impression that the explanation above is clear enough, now there is also an example of the Terraform plan which will be generated on each plan and is not reconciled.

[deiga]

@secustor I meant which issue number/URL.
If no issue exists yet, please create one :)

[deiga]

Thanks for the effort so far!

[deiga]

issue: Please use ConfigStateChecks instead

[deiga]

Please update the Description in the resource as well

[Copilot]

Pull request overview

These provider review instructions are being used.

Fixes perpetual drift for boolean organization custom-property defaults by correctly reading and stringifying boolean API values.

Changes:

• Handles true_false defaults during state refresh.
• Adds regression coverage for empty follow-up plans.
• Documents unsupported multi_select defaults.

Finding: The new test uses legacy assertion APIs instead of ConfigStateChecks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
github/resource_github_organization_custom_properties.go	Reads boolean defaults correctly.
github/resource_github_organization_custom_properties_test.go	Adds regression coverage.
templates/resources/organization_custom_properties.md.tmpl	Documents default-value limitations.
docs/resources/organization_custom_properties.md	Updates generated documentation.