Skip to content

chore: update turbostat#672

Merged
harp-intel merged 6 commits intomainfrom
chore-update-turbostat
Mar 27, 2026
Merged

chore: update turbostat#672
harp-intel merged 6 commits intomainfrom
chore-update-turbostat

Conversation

@harp-intel
Copy link
Copy Markdown
Contributor

@harp-intel harp-intel commented Mar 25, 2026

Updates turbostat to 2025.12.02 (from 6.19) kernel...requires GLIBC_2.33.
Improves parsing of turbostat output.

This pull request updates the handling of the turbostat tool in both the codebase and the build process. The main changes include improving the parsing logic for turbostat output, refining how package rows are identified, and updating the build system to fetch, build, and package a newer version of turbostat in a more consistent way.

Turbostat output parsing and logic improvements:

  • Improved the parseTurbostatOutput function to return an error if a row has more fields than headers, and to handle rows with missing fields more robustly by only mapping existing fields to headers.
  • Refined the isPackageRow function to only consider rows with "Core" == "0" as package rows, in addition to the existing "Package" checks.

Build system and packaging updates:

  • Updated the Makefile to use a newer kernel version (6.19.9) for building turbostat, and streamlined the build and packaging process to place the binary in bin/x86_64/.
  • Removed turbostat from the default tools-x86_64 build target and from the OSS source tarball, reflecting that it is now handled separately. [1] [2]
  • Ensured the Docker build process includes building turbostat by adding make turbostat to the Dockerfile.

Directory structure consistency:

  • Standardized binary output directories in the Makefile to always use bin/x86_64/, improving consistency across tools. [1] [2]

Makefile cleanup:

  • Removed unnecessary make clean step for turbostat from the reset target.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel merged commit 5207d18 into main Mar 27, 2026
5 checks passed
@harp-intel harp-intel deleted the chore-update-turbostat branch March 27, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant