helm: scope metrics-reader ClusterRole name to release#47
Merged
tkatila merged 1 commit intoJun 25, 2026
Merged
Conversation
The metrics-reader ClusterRole uses a generic hardcoded name that collides with identically-named resources from other operators (e.g. LVMS on OpenShift). Prefix the name with the Helm release name to avoid the conflict. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Anthony Byrne <abyrne@redhat.com>
abyrne55
force-pushed
the
fix/helm-metrics-reader-name-collision
branch
from
9d0e433 to
2430f7c
Compare
Contributor
|
Thanks @abyrne55! I think this is not the only one. Similar name collision seems to happen with other ClusterRoles also (metrics-auth-role, metrics-auth-rolebinding and manager-role at least). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metrics-readerClusterRole name with{{ .Release.Name }}to avoid collisions with identically-named resources from other operatorsProblem
The
metrics-readerClusterRole uses a generic hardcoded name. On OpenShift clusters where other operators (e.g. LVMS) create a ClusterRole with the same name,helm installfails with:Test plan
helm installon a cluster with a pre-existingmetrics-readerClusterRolehelm templateoutput shows<release-name>-metrics-reader🤖 Generated with Claude Code