[tooling] Improve reliability of make start-locally#1565
Merged
Conversation
the-glu
reviewed
Jul 13, 2026
| local status | ||
| status=$(docker inspect --format '{{.State.Status}}' "${container}" 2>/dev/null || true) | ||
| if [ "$status" = "restarting" ] || [ "$status" = "running" ]; then | ||
| docker stop -t 2 "${container}" >/dev/null 2>&1 || true |
Member
There was a problem hiding this comment.
Since there is already a forced stop bellow, is the if block not too much defensive? Or should we want a double stop, can't we just remove the if and stop it in everycase ?
barroco
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on benchmarking, I noticed that
make start-locallyoften failed with messages like:Gemini identified that this was probably happening when a container was restarting at the moment check_and_connect was called and suggested ensuring a known state when attempting
docker network connect. This seems to have fixed the issue as I haven't seen this type of failure since making this fix.