Skip to content

fix(security): prevent log forging and update tooling #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erlend Ellefsen (erlendellefsen) merged 3 commits into from
Jan 24, 2026
Merged

fix(security): prevent log forging and update tooling #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb25d1a
fix(security): prevent log forging and add workflow permissions
erlendellefsen Jan 24, 2026
42ae671
fix(security): prevent log forging and update tooling
erlendellefsen Jan 24, 2026
8ee2a72
Merge branch 'main' into fix/security-and-tooling-updates
erlendellefsen Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"isRoot": true,
"tools": {
"csharpier": {
"version": "0.30.6",
"version": "1.2.5",
"commands": [
"dotnet-csharpier"
"csharpier"
],
"rollForward": false
}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Check formatting
run: |
dotnet tool restore
dotnet csharpier . --check
dotnet csharpier check .

- name: Build
run: dotnet build --no-restore --configuration Release
Expand Down
4 changes: 2 additions & 2 deletions JsonApiToolkit.Tests/Extensions/IncludeFilterParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,8 @@ public void SeparateIncludeFilters_WithTooDeepNesting_ThrowsException()
var includePaths = new List<string> { "a.b.c.d" };

// Act & Assert
var exception = Assert.Throws<JsonApiBadRequestException>(
() => IncludeFilterParser.SeparateIncludeFilters(filters, includePaths)
var exception = Assert.Throws<JsonApiBadRequestException>(() =>
IncludeFilterParser.SeparateIncludeFilters(filters, includePaths)
);

Assert.Contains("Filter depth exceeds maximum", exception.Message);
Expand Down
12 changes: 6 additions & 6 deletions JsonApiToolkit.Tests/Extensions/QueryHelpersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ public void ConvertToPropertyType_WithValidEnumIgnoreCase_ConvertsCorrectly()
[Fact]
public void ConvertToPropertyType_WithInvalidEnum_ThrowsArgumentException()
{
var exception = Assert.Throws<FormatException>(
() => QueryHelpers.ConvertToPropertyType("InvalidStatus", typeof(TestStatus))
var exception = Assert.Throws<FormatException>(() =>
QueryHelpers.ConvertToPropertyType("InvalidStatus", typeof(TestStatus))
);

Assert.Contains(
Expand All @@ -45,8 +45,8 @@ public void ConvertToPropertyType_WithNullableEnum_ConvertsCorrectly()
[Fact]
public void ConvertToPropertyType_WithEmptyStringForEnum_ThrowsArgumentException()
{
var exception = Assert.Throws<FormatException>(
() => QueryHelpers.ConvertToPropertyType("", typeof(TestStatus))
var exception = Assert.Throws<FormatException>(() =>
QueryHelpers.ConvertToPropertyType("", typeof(TestStatus))
);

Assert.Contains("Invalid enum value '' for type 'TestStatus'", exception.Message);
Expand All @@ -71,8 +71,8 @@ public void ConvertToPropertyType_WithInt_ConvertsCorrectly()
[Fact]
public void ConvertToPropertyType_WithInvalidInt_ThrowsFormatException()
{
var exception = Assert.Throws<FormatException>(
() => QueryHelpers.ConvertToPropertyType("not-a-number", typeof(int))
var exception = Assert.Throws<FormatException>(() =>
QueryHelpers.ConvertToPropertyType("not-a-number", typeof(int))
);

Assert.Contains(
Expand Down
2 changes: 0 additions & 2 deletions JsonApiToolkit.Tests/JsonApiToolkit.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
Expand All @@ -24,5 +23,4 @@
<ItemGroup>
<ProjectReference Include="..\JsonApiToolkit\JsonApiToolkit.csproj" />
</ItemGroup>

</Project>
8 changes: 5 additions & 3 deletions JsonApiToolkit/JsonApiToolkit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
Expand All @@ -15,7 +14,7 @@
<RepositoryUrl>https://github.com/intility/Intility.JsonApiToolkit</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<PackageReadmeFile>README.md</PackageReadmeFile>

<!-- Generate XML documentation -->
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
Expand All @@ -25,7 +24,10 @@
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.3.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.2" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.2" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.2" />
<PackageReference
Include="Microsoft.Extensions.DependencyInjection.Abstractions"
Version="9.0.2"
/>
</ItemGroup>
<ItemGroup>
<None Include="README.md" Pack="true" PackagePath="\" />
Expand Down
Loading