-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(item-sliding): added specific animations for ionic #31103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
os-davidlourenco
wants to merge
9
commits into
next
Choose a base branch
from
ROU-12715
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a6ea277
feat(item-sliding): added specific animations for ionic
os-davidlourenco 9675242
feat(item-sliding): added specific swipe animations for ionic
os-davidlourenco 4ede42f
feat(item-sliding): added specific classes for swipe animations for i…
os-davidlourenco c0338ab
feat(item-sliding): corrected ionic thresholds
os-davidlourenco a247ac5
feat(item-sliding): added velocity validation for open options
os-davidlourenco 7468b4c
feat(item-sliding): improve full swipe animation separation
os-davidlourenco 6d983d2
feat(item-sliding): updated token library and ionic styles
os-davidlourenco 9b21fd3
Merge branch 'next' into ROU-12715
os-davidlourenco 7a45c30
feat(item-sliding): adopted suggestion from review
os-davidlourenco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| @use "./item-sliding.common"; | ||
| @use "../../themes/ionic/ionic.globals.scss" as globals; | ||
|
|
||
| // Transition utility classes | ||
| .item-sliding-transition-open .item { | ||
| transition: transform globals.$ion-transition-time-250 globals.$ion-transition-curve-smooth; | ||
| } | ||
|
|
||
| .item-sliding-transition-snapback .item { | ||
| transition: transform globals.$ion-transition-time-300 globals.$ion-transition-curve-bounce; | ||
| } | ||
|
|
||
| // Ionic full-swipe confirm sequence (replaces inline `transition` on item / expandable width) | ||
| .item-sliding-confirm-item-in .item { | ||
| transition: transform globals.$ion-transition-time-150 globals.$ion-transition-curve-base; | ||
| } | ||
|
|
||
| .item-sliding-confirm-item-back .item { | ||
| transition: transform globals.$ion-transition-time-500 globals.$ion-transition-curve-bounce; | ||
| } | ||
|
|
||
| ion-item-option.item-sliding-expandable-width-in { | ||
| transition: width globals.$ion-transition-time-150 globals.$ion-transition-curve-base; | ||
| } | ||
|
|
||
| ion-item-option.item-sliding-expandable-width-back { | ||
| transition: width globals.$ion-transition-time-500 globals.$ion-transition-curve-bounce; | ||
| } | ||
|
|
||
| .item-sliding-active-slide .item { | ||
| position: relative; | ||
|
|
||
| opacity: 1; | ||
| z-index: globals.$ion-z-index-100; | ||
| pointer-events: none; | ||
| will-change: transform; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| @use "./item-sliding.common"; | ||
| @import "../../themes/native/native.globals"; | ||
|
|
||
| .item-sliding-active-slide .item { | ||
| position: relative; | ||
|
|
||
| transition: transform 500ms cubic-bezier(0.36, 0.66, 0.04, 1); | ||
|
|
||
| opacity: 1; | ||
| z-index: $z-index-item-options + 1; | ||
| pointer-events: none; | ||
| will-change: transform; | ||
| } | ||
|
|
||
| // Native full-swipe animation (250ms ease-out; replaces inline styles on `ion-item`) | ||
| .item-sliding-active-slide.item-sliding-full-swipe-transition .item { | ||
| transition: transform 250ms ease-out; | ||
| } | ||
|
|
||
| // During drag on native (ios/md), disable transition — matches former inline `transition: none` | ||
| .item-sliding-active-slide.item-sliding-dragging .item { | ||
| transition: none; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.