Skip to content

fix(range): initialize ratios before first render #31194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puneetdixit200 wants to merge 1 commit into
base: main
Choose a base branch
from
+83 −0
Open

fix(range): initialize ratios before first render #31194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/components/range/range.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,8 @@ export class Range implements ComponentInterface {
this.min = isSafeNumber(this.min) ? this.min : 0;
this.max = isSafeNumber(this.max) ? this.max : 100;
this.step = isSafeNumber(this.step) ? this.step : 1;

this.updateRatio();
}

componentDidLoad() {
Expand Down
50 changes: 50 additions & 0 deletions core/src/components/range/test/modal/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<meta charset="UTF-8" />
<title>Range - Modal</title>
<meta
name="viewport"
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no"
/>
<link href="../../../../../css/ionic.bundle.css" rel="stylesheet" />
<script src="../../../../../scripts/testing/scripts.js"></script>
<script nomodule src="../../../../../dist/ionic/ionic.js"></script>
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script>
</head>

<body>
<ion-app>
<ion-content class="ion-padding">
<ion-button id="open-modal">Open Modal</ion-button>
</ion-content>
</ion-app>

<script>
const openModal = document.querySelector('#open-modal');

openModal.addEventListener('click', async () => {
const content = document.createElement('div');
content.innerHTML = `
<ion-content class="ion-padding">
<ion-range aria-label="Dual Knobs Range"></ion-range>
</ion-content>
`;

const range = content.querySelector('ion-range');
range.dualKnobs = true;
range.value = { lower: 20, upper: 80 };

const modal = Object.assign(document.createElement('ion-modal'), {
breakpoints: [0, 1],
component: content,
handle: true,
initialBreakpoint: 1,
});

document.body.appendChild(modal);
await modal.present();
});
</script>
</body>
</html>
31 changes: 31 additions & 0 deletions core/src/components/range/test/modal/range.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { expect } from '@playwright/test';
import { configs, test } from '@utils/test/playwright';

configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
test.describe(title('range: modal'), () => {
test('should render dual knob value when presented in a modal', async ({ page }) => {
await page.goto('/src/components/range/test/modal', config);
const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent');

await page.click('#open-modal');
await ionModalDidPresent.next();

const range = page.locator('ion-modal ion-range');
await expect(range).toBeVisible();

const knobPositions = await range.evaluate((el: HTMLIonRangeElement) => {
const shadowRoot = el.shadowRoot!;

return {
lower: (shadowRoot.querySelector('[part~="knob-handle-lower"]') as HTMLElement).style.left,
upper: (shadowRoot.querySelector('[part~="knob-handle-upper"]') as HTMLElement).style.left,
};
});

expect(knobPositions).toEqual({
lower: '20%',
upper: '80%',
});
});
});
});