Update FSharp.Core to 10.1#1536
Open
Thorium wants to merge 2 commits into
Open
Conversation
The FSharp.Core 10.1 update left a long line in the LanguageVersionShim constructor reflection that failed the CI `dotnet fantomas --check` gate, blocking every build job before the test phase. Reformat to satisfy it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to get FsAutoComplete to work with FSharp.Core 10.1.x.x
(To fix the known issues, like #1531)
So it updates FSharp.Core dependency and corresponding related fixed dependencies FSharp.Compiler.Service and FSharp.Analyzers.SDK
However, the FSharp.Compiler.Service seems to have some behavioural changes that will cause the FsAutoComplete test suite to fail, and since I'm not familiar with this project, I'm uncertain how to handle the situation. So I raised a question/report: dotnet/fsharp#19966