Bump k8s.io/* deps to v0.36.x and controller-runtime to v0.24.1#330
Conversation
- k8s.io/api, k8s.io/apimachinery, k8s.io/client-go: v0.35.0 -> v0.36.1 - sigs.k8s.io/controller-runtime: v0.23.3 -> v0.24.1 - Indirect: k8s.io/apiextensions-apiserver, k8s.io/apiserver, k8s.io/component-base: v0.35.0 -> v0.36.0 - go directive bumped to 1.26.0 (required by k8s.io/api v0.36.1) Signed-off-by: Rico Gu <yuanxun.gu@sap.com>
7ba3e88 to
6e64fc0
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughGo toolchain upgraded to 1.26.0 with Kubernetes dependencies refreshed to v0.36.x/v0.24.x versions. API scheme registration refactored from controller-runtime ChangesGo & Kubernetes upgrade with API scheme wiring refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Replace sigs.k8s.io/controller-runtime/pkg/scheme.Builder (deprecated in controller-runtime v0.24) with runtime.NewSchemeBuilder from k8s.io/apimachinery; register all types centrally in addKnownTypes() - Remove now-redundant SchemeBuilder.Register init() calls from type files - Regenerate zz_generated.deepcopy.go to match updated controller-gen output - Add missing SPDX header to internal/uki/oci_test.go Signed-off-by: Rico Gu <yuanxun.gu@sap.com>
golangci-lint v2.6 is built with Go 1.25 and refuses to run against a module declaring go 1.26.0 (required by k8s.io/* v0.36). Bump to v2.12 which supports Go 1.26. Also regenerate zz_generated.deepcopy.go without running make fmt afterwards; goimports was adding an explicit 'v1' alias to the k8s.io/api/core/v1 import that controller-gen does not emit, causing the check-codegen CI diff check to fail. Signed-off-by: Rico Gu <yuanxun.gu@sap.com>
internal/** is already covered by REUSE.toml; inline header not needed. Signed-off-by: Rico Gu <yuanxun.gu@sap.com>
golangci-lint v2.12 enforces goconst more strictly than v2.6: - Exclude goconst from test files (repeated string literals in test fixtures are intentional, not duplication problems) - Extract "ServerBootConfiguration" kind string to a named constant in server/helper.go Signed-off-by: Rico Gu <yuanxun.gu@sap.com>
afritzler
left a comment
There was a problem hiding this comment.
Just some small nit: I would follow the latest kubebuilder style schema and type registration. That way we stay consistent with the community style api setup.
k8s.io/* deps to v0.36.x and controller-runtime to v0.24.1
Per review feedback, align with the kubebuilder v4 scaffold pattern: - groupversion_info.go: NewSchemeBuilder with metav1.AddToGroupVersion only - httpbootconfig_types.go: init() registers types via s.AddKnownTypes - ipxebootconfig_types.go: same This keeps type registration local to each type file as intended by the kubebuilder design, rather than centralised in groupversion_info.go. Signed-off-by: Rico Gu <yuanxun.gu@sap.com>
|
@afritzler , all comments addressed, please have a look, thanks! |
Summary
Bumps the Kubernetes client libraries and controller-runtime to their latest releases, aligning the operator with the Kubernetes 1.36 ecosystem.
Changes Made
k8s.io/apik8s.io/apimachineryk8s.io/client-gosigs.k8s.io/controller-runtimek8s.io/apiextensions-apiserver(indirect)k8s.io/apiserver(indirect)k8s.io/component-base(indirect)godirectiveNotable Feature:
ClientsAllowCARotation(Beta in Kubernetes 1.36)client-go v0.36 includes the
ClientsAllowCARotationfeature gate, introduced as a Beta feature (enabled by default) in Kubernetes 1.36 via kubernetes/kubernetes#132922, which fixes kubernetes/kubernetes#119483.From the official release note:
This is relevant for long-running operators like boot-operator: CA rotations are handled transparently without dropping connections or requiring a restart.
Type of Change
Testing
make test)go build ./...)Summary by CodeRabbit
Chores
Refactor