Add multiplayer Plannotator review to Tasks#2
Draft
mmkal wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multiplayer task review to the workspace-backed Tasks app. Project members can switch an open task from Edit to Review, select markdown, and leave, edit, or delete Plannotator annotations. Other reviewers see changes live, and refresh restores them from Iterate.
Annotations use the checkout's existing Iterate workspace stream rather than a separate Plannotator service. The vessel stamps authors from the verified project session and stores namespaced add/update/remove events scoped to the task path. The existing collaborative editor remains the markdown source of truth.
This is stacked on the workspace collaboration proof in #1.
Included
@plannotator/uiand@plannotator/coreViewer/AnnotationPanel@plannotator/ui@0.28.0needs a small checked-in pnpm patch for TypeScript 5.9 response typing and itshighlight.jsmodule boundary. The review UI is client-only and lazy-loaded. Its upstream rich-document bundle is large (~1 MB gzip), but board/editor startup is unaffected.Proof
pnpm install --frozen-lockfilepnpm test— 26 testspnpm typecheckpnpm build