Force English locale only for test runs#479
Merged
Merged
Conversation
… false failures on foreign environments
kaklakariada
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running XmlParser tests on a non English environment, the expected exception messages don't match:
[INFO] Results: [INFO] [ERROR] Failures: [ERROR] XmlParserTest.testParsingInvalidXmlFormatFails:41 Expected: "Failed to parse file 'path': Content is not allowed in prolog." but: was "Failed to parse file 'path': Contenu non autorisé dans le prologue." [INFO] [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0For reproducibility purposes on all types of environment, we can simply force English locale for surefire tests execution in order to prevent false failures.