fix: enforce command queue timeouts#24
Open
itzptk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandQueuetimeouts by rejecting the queued promise when the timeout deadline expires.Closes #23
Verification
npm run test:node -- command-queuefailed withexpected 'pending' to be 'rejected'intimes out unresponsive tasks before continuing the queue.npm run test:node -- command-queue→ passed, 1 file / 2 tests.npm run test:node→ passed, 15 files / 117 tests.npm run test→ passed, 114 files / 252 tests. Existing dark-mode media-query warnings appeared on stderr, but the suite exited 0.npm run build→ passed (ng build --configuration productionandtsup --config tsup.config.ts).Notes
npm cidid not leave Electron's binary fully extracted in this scheduler worktree; I completed the local Electron extraction from npm's cached Electron zip before running the full node test suite. No tracked files were changed by that environment repair.