Skip to content

fix: enforce command queue timeouts#24

Open
itzptk wants to merge 1 commit into
mainfrom
fix/issue-23-command-queue-timeout-20260605002828
Open

fix: enforce command queue timeouts#24
itzptk wants to merge 1 commit into
mainfrom
fix/issue-23-command-queue-timeout-20260605002828

Conversation

@itzptk

@itzptk itzptk commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Enforces CommandQueue timeouts by rejecting the queued promise when the timeout deadline expires.
  • Aborts the task signal with the same timeout error, clears the timer, and advances the queue exactly once.
  • Adds regression coverage for a task that ignores its abort signal and never settles.

Closes #23

Verification

  • RED before fix: npm run test:node -- command-queue failed with expected 'pending' to be 'rejected' in times out unresponsive tasks before continuing the queue.
  • npm run test:node -- command-queue → passed, 1 file / 2 tests.
  • npm run test:node → passed, 15 files / 117 tests.
  • npm run test → passed, 114 files / 252 tests. Existing dark-mode media-query warnings appeared on stderr, but the suite exited 0.
  • npm run build → passed (ng build --configuration production and tsup --config tsup.config.ts).

Notes

  • npm ci did not leave Electron's binary fully extracted in this scheduler worktree; I completed the local Electron extraction from npm's cached Electron zip before running the full node test suite. No tracked files were changed by that environment repair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make queued commands fail when their timeout expires

1 participant