Skip to content

fix: keep release lockfile version aligned#38

Open
itzptk wants to merge 1 commit into
mainfrom
fix/issue-37-release-lockfile-version-20260605174120
Open

fix: keep release lockfile version aligned#38
itzptk wants to merge 1 commit into
mainfrom
fix/issue-37-release-lockfile-version-20260605174120

Conversation

@itzptk

@itzptk itzptk commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Updates the release version bump script to keep package-lock.json root versions aligned with package.json.
  • Treats either package.json or package-lock.json changes as release bump changes for --github-output.
  • Stages package-lock.json alongside package.json in the stable release finalization commit.
  • Adds a regression test that runs the release bump script against a temp fixture with a lockfile.

Closes #37

Verification

  • RED before fix: npm run test:node -- release-versioning failed with expected '1.2.2' to be '1.2.3' for packageLock.version.
  • npm ci passed.
  • npm run test:node -- release-versioning passed: 1 file, 2 tests.
  • npm run test:all passed: Angular tests 114 files / 252 tests, node tests 15 files / 117 tests. Note: local npm install scripts were blocked by the environment, so I manually extracted the cached Electron binary before the final full test run.
  • npm run build passed: Angular production build and tsup Electron build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the lockfile version in release bump commits

1 participant