Skip to content

fix: surface batch operation failures #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itzptk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: surface batch operation failures #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions src/app/core/services/package-actions.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,55 @@ describe('PackageActionsService', () => {

it('runs batch upgrade and shows toast', async () => {
const service = TestBed.inject(PackageActionsService);
await service.upgradeMany({ items: [{ kind: 'formula', name: 'ripgrep' }] });
await service.upgradeMany({
items: [
{ kind: 'formula', name: 'ripgrep' },
{ kind: 'formula', name: 'node' }
]
});
expect(facade.upgradeMany).toHaveBeenCalled();
expect(toast.push).toHaveBeenCalledWith(expect.stringContaining('Batch upgrade'), 'success');
expect(toast.push).toHaveBeenCalledWith(
'Batch upgrade finished (2/2 succeeded).',
'success'
);
});

it('shows error toasts for partial batch failures', async () => {
const service = TestBed.inject(PackageActionsService);
facade.upgradeMany.mockResolvedValueOnce({ succeeded: 1, failed: 1, results: [] });
facade.uninstallMany.mockResolvedValueOnce({ succeeded: 1, failed: 2, results: [] });
facade.pinMany.mockResolvedValueOnce({ succeeded: 0, failed: 1, results: [] });

await service.upgradeMany({
items: [
{ kind: 'formula', name: 'ripgrep' },
{ kind: 'formula', name: 'node' }
]
});
await service.uninstallMany({
items: [
{ kind: 'formula', name: 'ripgrep' },
{ kind: 'formula', name: 'node' },
{ kind: 'cask', name: 'firefox' }
]
});
await service.pinMany({ items: [{ kind: 'formula', name: 'node' }] });

expect(toast.push).toHaveBeenNthCalledWith(
1,
'Batch upgrade finished with failures (1/2 succeeded).',
'error'
);
expect(toast.push).toHaveBeenNthCalledWith(
2,
'Batch uninstall finished with failures (1/3 succeeded).',
'error'
);
expect(toast.push).toHaveBeenNthCalledWith(
3,
'Batch pin finished with failures (0/1 succeeded).',
'error'
);
});

it('shows pin undo toast', () => {
Expand Down
21 changes: 9 additions & 12 deletions src/app/core/services/package-actions.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,31 +139,28 @@ export class PackageActionsService {

async upgradeMany(request: BatchManyRequest): Promise<BatchJobResult> {
const result = await this.facade.upgradeMany(request);
this.toast.push(
`Batch upgrade finished (${result.succeeded}/${request.items.length} succeeded).`,
'success'
);
this.notifyBatchResult('upgrade', result, request.items.length);
return result;
}

async uninstallMany(request: BatchManyRequest): Promise<BatchJobResult> {
const result = await this.facade.uninstallMany(request);
this.toast.push(
`Batch uninstall finished (${result.succeeded}/${request.items.length} succeeded).`,
'success'
);
this.notifyBatchResult('uninstall', result, request.items.length);
return result;
}

async pinMany(request: BatchManyRequest): Promise<BatchJobResult> {
const result = await this.facade.pinMany(request);
this.toast.push(
`Batch pin finished (${result.succeeded}/${request.items.length} succeeded).`,
'success'
);
this.notifyBatchResult('pin', result, request.items.length);
return result;
}

private notifyBatchResult(action: 'upgrade' | 'uninstall' | 'pin', result: BatchJobResult, total: number): void {
const outcome = result.failed > 0 ? 'finished with failures' : 'finished';
const kind = result.failed > 0 ? 'error' : 'success';
this.toast.push(`Batch ${action} ${outcome} (${result.succeeded}/${total} succeeded).`, kind);
}

notifyPinSuccess(request: PinOneRequest): void {
this.toast.pushWithAction(`Pinned ${request.name}.`, 'success', {
label: 'Unpin',
Expand Down