Skip to content

Upgrade Android ecosystem and dependencies to android 11+#2679

Open
Copilot wants to merge 4 commits intomasterfrom
copilot/upgrade-android-buildscripts
Open

Upgrade Android ecosystem and dependencies to android 11+#2679
Copilot wants to merge 4 commits intomasterfrom
copilot/upgrade-android-buildscripts

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

The Android build scripts were using AGP 4.2.0, the deprecated com.android.support library, and outdated SDK/AndroidX versions.

gradle/libs.versions.toml

  • com.android.tools.build:gradle: 4.2.08.3.2
  • com.android.support:appcompat-v7:28.0.0androidx.appcompat:appcompat:1.6.1 (entry renamed android-support-appcompatandroidx-appcompat)
  • androidx-annotation: 1.3.01.7.1
  • androidx-lifecycle-common: 2.4.02.7.0

jme3-android-examples/build.gradle

AGP 8.x syntax and SDK target updates:

  • Added namespace (required by AGP 7.3+); removed package from AndroidManifest.xml
  • compileSdkVersion 28compileSdk 34
  • targetSdkVersion 28targetSdk 34
  • minSdkVersion 15minSdk 30 (Android 11+)
  • lintOptionslint
  • Removed buildToolsVersion (auto-managed by AGP 8.x)
  • Added compileOptions block (Java 11 source/target)
  • Updated appcompat dependency reference to libs.androidx.appcompat

common-android-app.gradle

  • Removed sourceCompatibility = '1.6'; Java compat is now set via compileOptions in the android DSL block

Copilot AI linked an issue Apr 3, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Upgrade com.android.tools.build to newer dependencies Upgrade Android ecosystem build dependencies Apr 3, 2026
Copilot AI requested a review from riccardobl April 3, 2026 22:23
@riccardobl
Copy link
Copy Markdown
Member

@copilot lets target android 11+ with java 11

Agent-Logs-Url: https://github.com/jMonkeyEngine/jmonkeyengine/sessions/89d6ac36-7802-42b9-bcf1-03c6108beeb7

Co-authored-by: riccardobl <4943530+riccardobl@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 3, 2026

@copilot lets target android 11+ with java 11

Done in 0be260eminSdk raised to 30 (Android 11 R) and compileOptions updated to JavaVersion.VERSION_11.

@riccardobl riccardobl changed the title Upgrade Android ecosystem build dependencies Upgrade Android ecosystem and dependencies to android 11+ Apr 3, 2026
@riccardobl riccardobl marked this pull request as ready for review April 3, 2026 22:28
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade com.android.tools.build

2 participants