Fix truncation of Atkinson and Floyd-Steinberg dithering routines in dithering.js#85
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
Owner
|
Please don't create ai generated pull requests without checking the code.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'atkinson' and 'bwr_floydsteinberg' branches in ditheringCanvasByPalette are truncated mid-function, causing syntax errors and incomplete pixel value updates. The fix completes the functions to properly apply error diffusion. Also corrects a typo in canvas2bytes where red/green/blue indices were swapped (b, g, b instead of r, g, b), which caused incorrect bit detection.