Add ASSIGN_NOPUSH to eliminate redundant assignment pushes#494
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new scalar-assignment opcode (ASSIGN_NOPUSH) to avoid redundant operand-stack pushes when an assignment’s result is immediately discarded, and updates the peephole optimizer, opcode definitions, AVM execution, and optimizer tests accordingly.
Changes:
- Add
ASSIGN_NOPUSHopcode and document distinct stack semantics vsASSIGN. - Extend the peephole optimizer to rewrite
ASSIGNfollowed byPOPintoASSIGN_NOPUSH. - Update the AVM assignment execution path to optionally skip pushing the assigned value; add tests asserting the optimizer behavior for statement vs expression assignments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/java/io/jawk/AwkTupleOptimizationTest.java | Adds optimizer tests and opcode-scanning helpers to validate folding behavior. |
| src/main/java/io/jawk/intermediate/Opcode.java | Introduces ASSIGN_NOPUSH and clarifies ASSIGN stack behavior in docs. |
| src/main/java/io/jawk/intermediate/AwkTuples.java | Adds peephole rewrite for ASSIGN + POP -> ASSIGN_NOPUSH and tuple construction helper. |
| src/main/java/io/jawk/backend/AVM.java | Executes ASSIGN_NOPUSH by assigning without re-pushing; removes redundant push/pop in a couple of internal assignment sites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASSIGN_NOPUSHopcode for scalar assignments whose result is immediately discardedASSIGN + POPintoASSIGN_NOPUSHTesting
mvn formatter:format test -Dtest=AwkTupleOptimizationTestmvn testmvn verify