feat: frogbot support for yarn workspaces#1343
Open
sean-perkins wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #798
Frogbot fails to apply dependency fixes in Yarn workspace (monorepo) projects. When a vulnerability is detected in a workspace package the fix command is run from the workspace package's subdirectory, but yarn upgrade/yarn up must be run from the workspace root against a specific workspace. This PR adds workspace detection.
A secondary bug is also fixed:
isYarnV1Projectpreviously ran the globalyarn --versionbinary to determine the project's Yarn version. Projects using Yarn Berry ship their own binary via .yarnrc.ymlyarnPath, so the global version could be wrong. The new implementation reads the version directly from theyarnPathfilename in .yarnrc.yml, which is faster and version-agnostic.