Feature/update packages#1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s toolchain and runtime requirements as part of a package refresh, including moving static file serving in the admin portal off node-static and onto the serve-static/finalhandler stack, and switching linting from semistandard to eslint.
Changes:
- Bumped project major version to
6.0.0and raised the Node.js engine requirement to>= 18.0.0. - Replaced
node-staticusage in the admin portal withserve-static+finalhandlerfor serving/status,/js, and/cssroutes. - Replaced
semistandardwith ESLint and applied small code tweaks (unused arg rename, object/export property shorthand) to satisfy the new lint rules.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| webroot/js/scripts.js | Renames an unused event parameter to comply with the new unused-args lint rule. |
| test/e2e.stubs.js | Uses object property shorthand for port (lint/style alignment). |
| test/e2e.admin.js | Uses object property shorthand for port in multiple contexts (lint/style alignment). |
| src/portals/admin.js | Switches static file serving from node-static to serve-static + finalhandler. |
| src/console/cli.js | Uses property shorthand in module.exports (lint/style alignment). |
| src/console/args.js | Uses property shorthand in module.exports (lint/style alignment). |
| package.json | Major version bump; swaps semistandard→eslint; updates dependencies; raises Node engine requirement. |
| CHANGELOG.md | Documents the 6.0.0 breaking changes and dependency/tooling updates. |
| .eslintrc.json | Adds ESLint configuration, including browser overrides and external webroot ignores. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.