Authored by Claude (Opus 4.8): Fix function-item-cast-to-integer warn… - #87
Merged
Merged
Conversation
…ings A recent rustc change added the `function_casts_as_integer` lint, which warns when a named function item is cast directly to an integer. The d3d9/d3d11 hooking code does this to compare addresses (detecting whether a vtable slot already points at our hook function to avoid double-hooking). Route the function-item operand through a pointer first (`hook_fn as *const () as usize`), as suggested by the compiler. The numeric address is identical, so all the "already hooked?" comparisons behave exactly as before. Only the function-item operands are changed; the function-pointer operands (vtable fields / stored real fn pointers) do not trigger the lint and are left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRC7uez7K5jPzx7Kyp5g8j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ings
A recent rustc change added the
function_casts_as_integerlint, which warns when a named function item is cast directly to an integer. The d3d9/d3d11 hooking code does this to compare addresses (detecting whether a vtable slot already points at our hook function to avoid double-hooking).Route the function-item operand through a pointer first (
hook_fn as *const () as usize), as suggested by the compiler. The numeric address is identical, so all the "already hooked?" comparisons behave exactly as before. Only the function-item operands are changed; the function-pointer operands (vtable fields / stored real fn pointers) do not trigger the lint and are left untouched.Claude-Session: https://claude.ai/code/session_01HRC7uez7K5jPzx7Kyp5g8j