Claude/mmlaunch registry root bug zcnasn - #88
Merged
Conversation
getMMRoot() located the ModelMod root by matching generic marker dirs (Bin/Logs/TPLib) relative to the current working directory. Under Wine/Proton the working dir can resolve to the unix root (drive Z:\), whose case-insensitive /bin matches the "Bin" marker, so getMMRoot() returned "Z:\". PeriodicUpdate then overwrote the registry MMRoot with that bogus value and the native loader could not find MMManaged.dll. Require a candidate root to actually contain a loadable MMManaged.dll (mirroring the native get_managed_dll_path search: "", Bin, Release, Debug) before accepting it; MMDotNet.sln is still trusted directly for dev checkouts. Invalid candidates now fall through to the existing registry value, so the correct root is preserved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VL1pRPGKznkc7W3ZSPsAc2
- Warn if the determined root doesn't have the dll - Do the detection just once at startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.