Refresh artifact-manager-s3 credentials from shared auth sources#1
Open
scheremisin wants to merge 1 commit into
Open
Refresh artifact-manager-s3 credentials from shared auth sources#1scheremisin wants to merge 1 commit into
scheremisin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWS_SHARED_CREDENTIALS_FILEand web-identity environment sources when no explicit JenkinscredentialsIdis configuredProblem
After moving Jenkins from EC2 to GKE, the controller started reading temporary AWS credentials from a Vault-rendered shared credentials file.
artifact-manager-s3currently resolves session credentials once, copies them into jcloudsSessionCredentials, and keeps using that fixed token. That works until the STS session expires, andcopyArtifactsis usually the first place it shows up asExpiredToken.What changed
This patch teaches the plugin to re-resolve credentials from the active auth source instead of pinning one token in memory at context creation time. For the GKE controller case that means rereading the latest values from
AWS_SHARED_CREDENTIALS_FILEafter Vault rotates them. It also supports web-identity envs for controller setups that rely on Kubernetes-issued tokens.Testing
mvn -Dmaven.repo.local=/private/tmp/amz-s3-fix/m2 -Dtest=S3BlobStoreConfigTest testmvn -Dmaven.repo.local=/private/tmp/amz-s3-fix/m2 -DskipTests package