Skip to content

Add international-product-matcher skill#14

Open
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-international-product-matcher
Open

Add international-product-matcher skill#14
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-international-product-matcher

Conversation

@norightsforlis

Copy link
Copy Markdown
Contributor

Summary

Adds the international-product-matcher skill: Finds fast-growing international products in a category and matches each to a JoomPro product, with a per-item import action.

Lives in skills/international-product-matcher/SKILL.md and is registered in the README skills table. Public behavior and user-visible workflow only — no internal service names, schema, or implementation details.

Public-Safety Checklist

  • No credentials, tokens, keys, or secrets.
  • No internal filesystem paths.
  • No private Slack, Jira, Notion, admin, or service URLs.
  • No private service names or implementation details.
  • No customer data or private product data.
  • Skill directory name matches SKILL.md frontmatter name.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@profunctor

Copy link
Copy Markdown
Collaborator

KISS review: this needs simplification before publishing.

The skill currently routes to “single-category international” and “all-categories international” skills that are not in this repo, promises “fast-growing” products while allowing non-growth ranking rules like top weekly revenue, and tells agents to search/build JoomPro links without naming a supported tool, URL template, or confidence rule.

I’d reduce this to one executable contract: category in, international ML listings out, rank by a concrete supported metric, include a JoomPro product link only when a supported lookup returns a confident match, otherwise show . Also drop the duplicate Importar/JoomPro columns.

@profunctor

Copy link
Copy Markdown
Collaborator

Review — international-product-matcher

Summary: Given one Mercado Livre (Brasil) category, uses JoomPulse to find fast-growing international/imported listings, shortlists the fast growers, and matches each to a JoomPro source product. Output is a read-only markdown table (price, est. weekly sales/revenue, rating, reviews, time on air, shipping, listing type, seller medal) with a per-item "Importar" JoomPro link plus an MLB-to-JoomPulse link.

Findings:

  • major — Dangling references to non-existent sibling skills ("single-category international skill", "all-categories international skill" — the "international trio"). Neither exists on main and this PR doesn't add them. Remove or land the siblings first; prefer canonical slugs.
  • major — Description overload hurts triggering. The frontmatter description is one ~190-word block mixing triggers, the full column list, the estimate caveat, and routing notes. The buried trigger phrases ("imported winners I can source", "import these with a button") are unnatural and unlikely to match real requests. Trim to a crisp summary + natural triggers.
  • minor — Trigger overlap with ml-product-analysis; the distinguishing signal (international/imported + JoomPro import) lives deep in the description. Sharpen it so the two don't compete.
  • nit — "Fast-growing" is non-deterministic (no threshold/default ordering/limit), so runs aren't reproducible. Add a default (e.g. top N by estimated weekly revenue).
  • note — Please confirm "JoomPro" is acceptable to name in a public repo (see related comment on Add fast-growing-international-products skill #13).

Frontmatter shape, section structure, estimate disclaimer, README registration, and folder-name == name all match conventions. No secrets or write operations.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants