Fix: transaction id#71
Open
sc-vt wants to merge 2 commits into
Open
Conversation
sc-vt
commented
Mar 31, 2026
sc-vt
commented
- rfc3489 does not use magic cookie in transaction id
- the last 4 bytes of transaction id were not populated
Owner
|
It took me a couple of minutes to see the bug. But yeah, that for-loop is truncated. And if we really wanted to be pedantic, we'd make sure that the first 4 random bytes in legacy mode are definitely NOT 0x2112A442. It's a 1 in 4 billion chance that would ever happen, but the stunserver has handled up to a billion transactions per day. There's all kinds of simple ways to ensure this never happens. Can you address that and add some unit tests? |
…okie. Add unit tests to validate transaction id in legacy and non-legacy modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.