Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 90.73% 91.00% +0.26%
==========================================
Files 16 16
Lines 2300 2378 +78
==========================================
+ Hits 2087 2164 +77
- Misses 213 214 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So I built a draft implementation for Moreau.jl using this branch; it worked really well! Thank you. A few issues that popped up:
Overall, I think a bunch of this is just API differences, and probably can't be fixed at this point, but figured it was worth mentioning. |
| # | ||
| # min (1/2) x'Qx + c'x | ||
| # s.t. Ax = b | ||
| # ───────────────────────────────────────────────────────────────────────────── |
There was a problem hiding this comment.
Did you copy this from #344?
Otherwise, this raises a lot of questions from a copyright perspective that I don't know we're well prepared to handle.
In this case it's okay. But how do we have any control that the code is coming from a JuMP-dev repo and not some external source? And even it if is from a JuMP repo, what if the license is not MIT? And how can we ensure we keep any appropriate copyright etc?
There was a problem hiding this comment.
There must be a tool for searching online and verifying.
There was a problem hiding this comment.
Sure, but do I need to do that for every PR? When someone manually submits a PR we trust them that they haven't copied someone (without declaring it). I don't have that trust if it's Claude.
There was a problem hiding this comment.
Cant we run the auto check in CI?
There was a problem hiding this comment.
Oh you mean if there is such a tool, then we could run it in CI. The problem is: which tool?
There was a problem hiding this comment.
Yes, it was copied from there. I agree it is a concern
First commit by Claude Code during our meeting based on this prompt #344 (comment)
Then I took control