Skip to content

Remove ParallelTestRunner in favor of serial tests #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odow wants to merge 7 commits into from
+16 −7
Closed

Remove ParallelTestRunner in favor of serial tests #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40d341b
Remove ParallelTestRunner in favor of serial tests
odow Jul 6, 2026
d2f77d9
Modify silent mode settings in test_vOptLib_runtests
odow Jul 6, 2026
efc64ca
Modify silent mode settings in test function
odow Jul 7, 2026
548c328
Apply suggestion from @odow
odow Jul 7, 2026
a41f984
Update MultiObjectiveAlgorithms.jl
odow Jul 7, 2026
353a7e5
Update
odow Jul 7, 2026
9f5c6bd
Update
odow Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MultiObjectiveAlgorithms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ mutable struct Optimizer <: MOI.AbstractOptimizer
inner = MOI.instantiate(optimizer_factory; with_cache_type = Float64)
if MOI.supports(inner, MOI.Silent())
# Make the default for `SilentInner` true.
MOI.set(inner, MOI.Silent(), true)
# MOI.set(inner, MOI.Silent(), true)
end
return new(
inner,
Expand Down
3 changes: 2 additions & 1 deletion test/algorithms/test_EpsilonConstraint.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ end
function test_vOptLib_runtests()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.EpsilonConstraint())
MOI.set(model, MOI.Silent(), true)
# MOI.set(model, MOI.Silent(), true)
# MOI.set(model, MOA.SilentInner(), false)
vOptLib.run_tests(model)
return
end
Expand Down
3 changes: 2 additions & 1 deletion test/algorithms/test_KirlikSayin.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ end
function test_vOptLib_runtests()
model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.KirlikSayin())
MOI.set(model, MOI.Silent(), true)
# MOI.set(model, MOI.Silent(), true)
MOI.set(model, MOA.SilentInner(), false)
vOptLib.run_tests(model)
return
end
Expand Down
12 changes: 9 additions & 3 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ for (root, dirs, files) in walkdir(@__DIR__)
end
end

import MultiObjectiveAlgorithms
import ParallelTestRunner
# import MultiObjectiveAlgorithms
# import ParallelTestRunner
#
# ParallelTestRunner.runtests(MultiObjectiveAlgorithms, ARGS; testsuite)

ParallelTestRunner.runtests(MultiObjectiveAlgorithms, ARGS; testsuite)
# Run the tests in serial. HiGHS intermittently segfaults on v1.10 when using
# ParallelTestRunner for some reason.
for file in keys(testsuite)
include(file)
end
3 changes: 2 additions & 1 deletion test/test_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ function test_printing()
@test MOI.supports(model, MOI.Silent())
@test MOI.get(model, MOI.Silent()) == false
MOI.set(model, MOI.Silent(), true)
MOI.set(model, MOA.SilentInner(), true)
open(joinpath(dir, "log2.txt"), "w") do io
redirect_stdout(() -> MOI.optimize!(model), io)
return
Expand All @@ -279,7 +280,7 @@ end
function test_printing_silent_inner()
model = MOA.Optimizer(HiGHS.Optimizer)
@test MOI.supports(model, MOA.SilentInner())
@test MOI.get(model, MOA.SilentInner()) == true
# @test MOI.get(model, MOA.SilentInner()) == true
MOI.set(model, MOA.SilentInner(), false)
@test MOI.get(model, MOA.SilentInner()) == false
MOI.set(model, MOI.Silent(), true)
Expand Down
Loading