Complete blueprint.js removal - #1682
Merged
Merged
Conversation
Contributor
Bundle Size Report ✅ PASS
Top Changes
Generated by build-size-diff Commit: a0c85cd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1450
Summary
Removes Blueprint.js as a UI dependency from
mapguide-react-layout, completing the migration to the toolkit-agnosticIElementContextabstraction. The default (and now only) provider isMinimalProvider— a zero-dependency implementation using semantic HTML and CSS custom properties.What changed
Dependencies removed
@blueprintjs/core— removed fromdevDependencies,peerDependencies, andpeerDependenciesMeta@blueprintjs/icons— removed frompeerDependenciesandpeerDependenciesMetaBLUEPRINT_NAMESPACEdefine,iconSvgPathsaliases in Vite & Storybook)Files deleted
src/components/elements/providers/blueprint/(22 files) — the entire Blueprint providerstdassets/bp-icons.js— SVG path subset (paths now embedded in minimal provider)Visual parity improvements
#137CBD, danger#DB3737, warning#D9822B, success#0F9960)Leaked
bp3classes cleaned upsrc/styles/index.css— removed.bp3-select:afterand.bp3-darkrulessrc/containers/measure.tsx—bp3-label→FormGroupelementviewer/css/limegold.css,viewer/css/turquoise-yellow.css—bp3-tab*→mrl-tab*bp3-heading→HeadingelementNaming sanitized
svg-icons.tsx:IBlueprintPathMap→ISvgPathMap,BP_ICONS_20→SVG_ICON_PATHS_20,getBlueprintIconPaths→getSvgIconPathsicon-map.ts: parameterblueprintName→iconNameneo-map-viewer.tsx,map-viewer-swipe.tsx,flyout-region.tsx— Blueprint references removedDocumentation updated
docs_dev/content/UI_CUSTOMIZATION.md— removed Blueprint provider section; updated reference linkdocs_dev/content/README.md,README.md— removed Blueprint from creditsdocs_dev/content/KNOWN_ISSUES.md— removed resolved Blueprint backdrop issuedocs_dev/content/VISUAL_REGRESSION.md— updated example textsrc/stories/docs/common-elements.md— updated toolkit descriptionDONOTUPGRADE.md— updated decoupling noteTest comments updated
test/containers/add-manage-layers.spec.tsxtest/containers/selection-panel.spec.tsxBreaking changes
None for end users. Blueprint was already an optional peer dependency and not included in the default
viewer.jsbundle. TheMinimalProviderwas already the default since 0.15.Users who explicitly mounted the Blueprint provider in custom bundles will now fall through to
MinimalProvider. They should remove theBpProviderimport and Blueprint CSS imports from their custom entry points.Manual testing plan
yarn run build:prodyarn test:visual:updateto regenerate baselines, thengit diff visual-snapshots/to review visual changes