⚡ Bolt: Inline duration formatting to reduce allocations#86
Conversation
Inlines track duration formatting in the high-frequency `App::update` loop directly into a single `format!` macro, eliminating the need for string-allocating helper functions `format_duration` and `format_duration_seconds`. This avoids 4 intermediate `String` heap allocations per frame while maintaining the exact same UI output. Unused helper functions were removed.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Inlines duration formatting logic directly into
format!macros inApp::updateand removes the old string-returning helper functions (format_durationandformat_duration_seconds).🎯 Why:
App::updateis called frequently (every ~500ms). The previous approach allocated intermediateStringobjects via helper functions and passed them into an outerformat!macro.📊 Impact: Eliminates 4 intermediate
Stringheap allocations per playback position update, reducing garbage generation in the TUI's hot path without changing the visual output.🔬 Measurement: Verify via
cargo buildandcargo test --bin amcli uito ensure the logic remains correct. The code compiles without warnings.PR created automatically by Jules for task 13573185752327949433 started by @juntaochi