Fix out of bounds memory read in add_compile_string#165
Open
sashashura wants to merge 1 commit intok-takata:masterfrom
Open
Fix out of bounds memory read in add_compile_string#165sashashura wants to merge 1 commit intok-takata:masterfrom
add_compile_string#165sashashura wants to merge 1 commit intok-takata:masterfrom
Conversation
sashashura
added a commit
to sashashura/fluent-bit
that referenced
this pull request
Sep 5, 2022
Temporary fix until k-takata/Onigmo#165 is merged Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
sashashura
added a commit
to sashashura/fluent-bit
that referenced
this pull request
Sep 5, 2022
Temporary fix until k-takata/Onigmo#165 is merged Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
sashashura
added a commit
to sashashura/onigmo-1
that referenced
this pull request
Sep 7, 2022
Temporary fix until k-takata/Onigmo#165 is merged Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
sashashura
added a commit
to sashashura/onigmo-1
that referenced
this pull request
Sep 7, 2022
Temporary fix until k-takata/Onigmo#165 is merged Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
edsiper
pushed a commit
to fluent/onigmo
that referenced
this pull request
Sep 11, 2022
Temporary fix until k-takata/Onigmo#165 is merged Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes out of bounds memory read in
add_compile_stringrevealed by fuzzing fluent-bit:https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46086
The root cause is that a call to
enclenincompile_string_noderesults in a call toonigenc_mbclen_approximate.When the value of
ppassed to the function is\xf2even though it is the last byte in multibyte sequince (the next byte is unexpected string terminator \0) theonigenc_mbclen_approximatereturns it's size as 4. The size is added to the overall string length and results in reading past the end of the string.