Conversation
Treat non-caller TaskCanceledException failures as request timeouts and route them through the existing backoff retry flow. Keep caller cancellation behavior unchanged so explicitly canceled requests are not retried. Add tests for retrying timed-out requests and for avoiding retries when cancellation comes from the caller.
Cover JSON, Newtonsoft.Json, XML, and DataContract XML requests using gzip and deflate content. Verify retries preserve compressed serialized request bodies after connection failures and request timeouts. Verify caller cancellation does not retry compressed serialized requests.
Test helper utilities have been moved from individual test projects to a new shared Kampute.HttpClient.TestSupport project. All test projects now reference this shared library. Test code has been updated to use the new helpers for mocking, compressed content, and retry strategies, improving maintainability and consistency. Some test assertions were refined for clarity and reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several documentation improvements, version bumps for serializer extension packages, and a minor reliability fix in the HTTP client core. The main highlights are the addition of a comprehensive documentation homepage, improved and corrected links in the
README.md, and updated package versions for all serializer extensions to2.5.1. Additionally, a cancellation check was added to the HTTP retry logic for better responsiveness.Documentation and User Guidance Improvements:
docs/welcome.mdfile providing an in-depth overview, quick start, and usage examples forKampute.HttpClient, including explanations of core features, serializer packages, retry strategies, error handling, and extensibility.README.mdto correct and improve links to documentation and serializer extension packages, ensuring users are directed to the correct HTML documentation pages. [1] [2]Build and Packaging Updates:
Kampute.HttpClient.Json,Kampute.HttpClient.NewtonsoftJson,Kampute.HttpClient.Xml,Kampute.HttpClient.DataContract) from2.5.0to2.5.1to reflect recent changes. [1] [2] [3] [4]Documentation Build System Enhancements:
kampose.jsonto include documentation topics, adjust asset paths, and improve footer information for the generated documentation site. [1] [2]