add integration tests - #89
Open
katbyte wants to merge 5 commits into
Open
Conversation
Conflict resolutions and integration fixes: - test.yaml: kept branch's path filters, took main's checkout/setup-go@v7 with go-version-file - makefile: kept branch's split unit/integration test target, added main's -race flag to both - lib/gh, lib/tc: kept branch's APIURL/RawURL/baseURL overrides, adopted main's named results and http.MethodPost (main's lint enforces unnamedResult) - lib/gh/gh.go: reworked APIURL override for go-github v89's option-based client construction (BaseURL is no longer an assignable field) using github.WithURLs at client creation - test harness: pass openPRs via newMockGitHub so the write happens before the mock server starts; fixes a data race found by main's new -race test flag - .golangci.yml: exclude _test.go from goconst (table-driven tests repeat literals by design) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.