Fixing issues related to NMDC studies and data objects#208
Merged
jeff-cohere merged 16 commits intomainfrom Apr 16, 2026
Merged
Fixing issues related to NMDC studies and data objects#208jeff-cohere merged 16 commits intomainfrom
jeff-cohere merged 16 commits intomainfrom
Conversation
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NMDC database integration to support workflows that reference multiple biosamples per data object, and bumps the service patch version.
Changes:
- Bump service patch version from
0.11.2to0.11.3. - Update NMDC workflow metadata retrieval to return multiple biosamples instead of erroring when more than one is present.
- Adjust NMDC tests to reflect the renamed multi-biosample workflow helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/version.go | Patch version bump to reflect the feature change. |
| databases/nmdc/database.go | Switch workflow biosample handling from single biosample to multiple biosamples. |
| databases/nmdc/database_test.go | Rename/update tests for the new multi-biosample workflow helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 62.40% 61.42% -0.99%
==========================================
Files 34 34
Lines 4533 4521 -12
==========================================
- Hits 2829 2777 -52
- Misses 1391 1426 +35
- Partials 313 318 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeff-cohere
changed the title
…r statuses. * NMDC biosamples are no longer transferred -- only data objects * File IDs for data objects are prefixed with their study IDs so we don't need the graph. * Several errors are now properly propagated and can affect the success of a transfer.
This method is internal and tested indirectly. I've added a comment to document its needs.
jeff-cohere
requested review from
Copilot and
mattldawson
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need the graph.
transfer.
-vflag)