Modifications to JDP proxy to allow necessary KBERDL transfers#216
Merged
Conversation
jeff-cohere
added
the
JDP
Contributor
|
mattldawson
approved these changes
May 14, 2026
jeff-cohere
changed the title
Collaborator
Author
|
I'm testing these new features in Spin, and so far it seems like everything is working properly. |
This might not work long-term, but it's worth a try.
jeff-cohere
force-pushed
the
add-jdp-datasets-search-param
branch
from
79764c7 to
840b7eb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 59.51% 59.37% -0.15%
==========================================
Files 34 34
Lines 4547 4605 +58
==========================================
+ Hits 2706 2734 +28
- Misses 1529 1553 +24
- Partials 312 318 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some features that allow us to transfer files to KBERDL:
datasetsJDP search parameter is added to the set of JDP-specific parameters. We needed this to get the file IDs for an IMG Virus dataset.search/by_file_idsendpoint) seem flaky, sometimes dropping handfuls of metadata in the response, so a more elaborate request structure gathers missing ones (not perfect, but seems good enough for now).Closes #219
Closes #220