Feat/interface#294
Merged
Merged
Conversation
Signed-off-by: Jakob Beckmann <f4z3r-github@pm.me>
Signed-off-by: Jakob Beckmann <f4z3r-github@pm.me>
Contributor
Author
|
I will update to a service oriented implementation in the coming week, so that it is more aligned with how it is implemented in Python and Go. I think it would be nice to have Lua ergonomic functions like |
Contributor
|
Good Job! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
See kcl-lang/kcl#388
2. What is the scope of this PR (e.g. component or file name):
Improving ergonomics and features supported by the Lua SDK.
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Renamed the
exec_programtorunto be in line with mature SDKs such as the Go one, and have nicer function naming. Allow to pass either a simple file path or an array of file paths torun. Also addformatfunction in line with other SDK's format functions.Improved README to be nicer to get started with the SDK.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
exec_programrenamed torun.5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: