Fix tests#3
Open
jr636-coala wants to merge 21 commits into
Open
Conversation
https://arxiv.org/pdf/1707.05881.pdf : pg12, "there is no acyclically justified configuration of the event structure that reads a value other than 0 for x."
Bridging says that imm should disallow the rfi-not-preserved behaviour. Repairing sequential consistency does say that it disallows this behaviour, but it says it does it incorrectly, and since our rc11 is the fixed version we should allow it.
This test had no model set so was not passing tests as it requires some amount of coherence. I also split it into two tests as there were two assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some changes to make FADD work correctly, and made the tests more consistent.
Also
Bridging says that imm should disallow the rfi-not-preserved behaviour. Repairing sequential consistency does say that it disallows this behaviour, but it says it does it incorrectly, and since our rc11 is the fixed version we should allow it.