Make audit log end dates exclusive#199
Merged
Merged
Conversation
hiroTamada
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--endvalues as the exclusive boundary sent to the APITesting
make testmake buildmake lint(golangci-lintis not installed)Note
Medium Risk
Changes CLI time-window semantics for date-only
--end, which can shrink results for scripts that relied on inclusive end-of-day behavior.Overview
audit-logs searchnow sends--endto the API as an exclusive boundary instead of extending date-only values by 24 hours so the whole calendar day was included.parseAuditLogTimeno longer returns adateOnlyflag; date strings like2026-07-01are passed through as midnight UTC on that date. The--endflag help text now documents exclusivity, and the regression test asserts a window from2026-06-30through exclusive2026-07-01rather than treating same-day start/end as a full day.Reviewed by Cursor Bugbot for commit 9e3be94. Bugbot is set up for automated code reviews on this repo. Configure here.