Skip to content

Make audit log end dates exclusive#199

Merged
yummybomb merged 1 commit into
mainfrom
hypeship/exclusive-audit-log-end
Jul 10, 2026
Merged

Make audit log end dates exclusive#199
yummybomb merged 1 commit into
mainfrom
hypeship/exclusive-audit-log-end

Conversation

@yummybomb

@yummybomb yummybomb commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve date-only --end values as the exclusive boundary sent to the API
  • remove the no-longer-needed date-only parsing marker
  • clarify the CLI help text and cover the boundary with a regression test

Testing

  • make test
  • make build
  • not run: make lint (golangci-lint is not installed)

Note

Medium Risk
Changes CLI time-window semantics for date-only --end, which can shrink results for scripts that relied on inclusive end-of-day behavior.

Overview
audit-logs search now sends --end to the API as an exclusive boundary instead of extending date-only values by 24 hours so the whole calendar day was included.

parseAuditLogTime no longer returns a dateOnly flag; date strings like 2026-07-01 are passed through as midnight UTC on that date. The --end flag help text now documents exclusivity, and the regression test asserts a window from 2026-06-30 through exclusive 2026-07-01 rather than treating same-day start/end as a full day.

Reviewed by Cursor Bugbot for commit 9e3be94. Bugbot is set up for automated code reviews on this repo. Configure here.

@yummybomb yummybomb marked this pull request as ready for review July 10, 2026 14:24
@yummybomb yummybomb requested a review from hiroTamada July 10, 2026 14:59
@yummybomb yummybomb merged commit d49a910 into main Jul 10, 2026
7 checks passed
@yummybomb yummybomb deleted the hypeship/exclusive-audit-log-end branch July 10, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants