Reduce Chromium restart wait time#314
Closed
chruffins wants to merge 1 commit into
Closed
Conversation
- Simplify waitForPort in chromium-launcher: remove SO_REUSEADDR disable, use plain net.Listen for accurate port checks - Refactor playwright-daemon timeout: replace AbortSignal.timeout with Promise.race + setTimeout, remove withTimeout helper - Delete unused wsdrain package and its registry from all call sites - Remove wsdrain dependency from wsproxy, chromedriverproxy, devtoolsproxy, and api server - Update capmonster defaultSettings to include HCaptcha
chruffins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(See KERNEL-1525)
Root cause:
waitForPortin chromium-launcher probed port 9223 withSO_REUSEADDRdisabled. After CDP health checks, TIME_WAIT sockets are always present on that port. The probe failed for the full 5s timeout, then Chromium bound immediately anyway (since it usesSO_REUSEADDR).Fix: Use Go's default
net.Listen, which setsSO_REUSEADDRand matches Chromium's apparent DevTools bind behavior. The probe still waits if an activeLISTENfrom the old process is lingering afterSIGKILL, but no longer blocks on harmlessTIME_WAITsockets from prior CDP connections.