Skip to content

feat: add Table column visibility, order, and resize options - #2036

Open
mentonin wants to merge 1 commit into
kernelci:mainfrom
profusion:georg/feat/col-layout
Open

feat: add Table column visibility, order, and resize options#2036
mentonin wants to merge 1 commit into
kernelci:mainfrom
profusion:georg/feat/col-layout

Conversation

@mentonin

Copy link
Copy Markdown
Contributor

Summary

  • Partial fix for Custom column/header selection and width #2008: column visibility, reorder, and resize - no persistence of any kind.
  • Fixes Table columns should have fixed/consistent size #420 content-independent widths (no jump on sort/pagination)
  • Shared useLayoutTable entry point drives Tree, Hardware, Issues, Builds, Boots, and hardware tree picker tables.
  • Interior resize handles redistribute width between neighbors (table width fixed); outer edges can grow/shrink the table. Manual resize ignores maxWidth.
  • Status column minWidths sized for Build (3-digit), Boot (4-digit), and Test (5-digit) counts.
  • Tests / IndividualTests tables intentionally left out (pending feat: unify hierarchical test table grouping #2030 grouping rework). Persistence and share/export URL are follow-ups.

Test plan

  • Tree / Hardware / Issues listing: Columns menu toggles and reorders; row-header columns
    stay leftmost and visible
  • Drag interior handles: neighboring columns trade width; table width unchanged
  • Drag outer (first left / last right) handles: table width changes; horizontal scroll when needed
  • Reset marker clears manual width for that column
  • Sort / paginate: column widths do not jump with content
  • Build/Boot/Test status badges fit 3/4/5-digit counts at default mins without clipping

Related Issues

Give users control over the table layout with content-independent
widths so columns no longer jump when sorting or paginating.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
@MarceloRobert

Copy link
Copy Markdown
Contributor

Could you add screenshots and/or videos, please?

@felipebergamin felipebergamin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

I'm not sure about how it is looking on large screens.

Comparing your branch to prod, the table is now narrower, leaving extra whitespace around it.

Image Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both BootsTable.tsx and BuildsTable.tsx have the details column, which is the only column that allows navigation to the details page. Clicking on the other cells only opens the right drawer.

I'm wondering if it's okay to allow the user to hide the only way they have to navigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table columns should have fixed/consistent size

3 participants