Skip to content

Add migration script for confd: prevent IP addresses on bridge ports#1454

Merged
troglobit merged 1 commit intomainfrom
add-migrate-script
Mar 25, 2026
Merged

Add migration script for confd: prevent IP addresses on bridge ports#1454
troglobit merged 1 commit intomainfrom
add-migrate-script

Conversation

@mattiaswal
Copy link
Copy Markdown
Contributor

Unfortunatly the fix was entered in 25.10, but confd was not stepped up until 25.11, so this should be for 25.10 but now it is for confd version 1.6 (infix 25.11), as close as we can get.

this is a follwup for commit 7e37fc4

confd: prevent IP addresses on bridge ports

Bridge ports should not have IP addresses configured. The IP address should be configured on the bridge interface itself, not its member ports.

Add YANG must expression to enforce this rule at configuration time.

Fixes #1122

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

Unfortunatly the fix was entered in 25.10, but confd was not stepped
up until 25.11, so this should be for 25.10 but now it is for confd
version 1.6 (infix 25.11), as close as we can get.

this is a follwup for commit 7e37fc4

confd: prevent IP addresses on bridge ports

Bridge ports should not have IP addresses configured. The IP address
should be configured on the bridge interface itself, not its member ports.

Add YANG must expression to enforce this rule at configuration time.

Fixes #1122
@mattiaswal mattiaswal requested a review from troglobit March 25, 2026 10:13
Copy link
Copy Markdown
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@troglobit troglobit merged commit 5b12113 into main Mar 25, 2026
9 checks passed
@troglobit troglobit deleted the add-migrate-script branch March 25, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IP address is allowed on interfaces in a bridge

2 participants