Isolate integration test settings to prevent clobbering user config#101
Merged
sarroutbi merged 1 commit intoMay 21, 2026
Merged
Conversation
The curl integration tests issue PUT requests to /api/settings/keylime and /api/settings/certificates, which trigger persist_settings() and overwrite ~/.config/keylime-webtool/settings.toml. This silently replaces the user's real Verifier/Registrar URLs with Mockoon test values and deletes the mTLS certificate configuration, causing real Keylime services to appear as DOWN after every pre-commit run. Set KEYLIME_WEBTOOL_CONFIG to a temporary file before starting the test backend so all settings writes go to an isolated location. The temp file is removed in the cleanup trap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curl integration tests issue PUT requests to /api/settings/keylime and /api/settings/certificates, which trigger persist_settings() and overwrite ~/.config/keylime-webtool/settings.toml. This silently replaces the user's real Verifier/Registrar URLs with Mockoon test values and deletes the mTLS certificate configuration, causing real Keylime services to appear as DOWN after every pre-commit run.
Set KEYLIME_WEBTOOL_CONFIG to a temporary file before starting the test backend so all settings writes go to an isolated location. The temp file is removed in the cleanup trap.