First forecast test version#359
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an initial implementation of forecast retrieval/parsing for GeoSphere Austria data in ZamgData, along with tests and related developer-environment/tooling updates.
Changes:
- Add forecast endpoints plus helpers to extract “current” forecast values and trim forecast payloads to “now onward”.
- Add initial forecast tests and adjust existing async-failure testing to work with
aresponsesv3. - Update dev tooling/config (Poetry dependency groups, pre-commit hooks, devcontainer/Dockerfile, VS Code launch config).
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
src/zamg/zamg.py |
Adds forecast URLs, forecast caching, parsing helpers, and forecast parameter/metadata handling. |
tests/test_zamg.py |
Adds forecast-related tests and adjusts a connection-failure test to avoid old aresponses behavior. |
src/zamg/__init__.py |
Import formatting cleanup for exception exports. |
requirements.txt |
Bumps aresponses to 3.0.0. |
requirements_test.txt |
Bumps aresponses to 3.0.0. |
pyproject.toml |
Moves dev dependencies to Poetry’s dependency group format. |
forecast_test.py |
Adds a new example script to manually exercise forecast calls (currently named like a pytest test module). |
examples/read_data.py |
Minor formatting (blank line). |
Dockerfile.dev |
Simplifies apt setup and consolidates pip installs with constraints. |
control.py |
Minor formatting (blank line). |
.vscode/launch.json |
Switches debugger type to debugpy and adds a launch config for forecast_test.py. |
.pre-commit-config.yaml |
Adds isort, removes reorder-python-imports, and tweaks bandit deps. |
.flake8 |
Adds E203 ignore (Black compatibility). |
.devcontainer/devcontainer.json |
Removes Intellicode extension from the devcontainer extensions list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.