APIdocument-3726: ガントチャートプラグイン ライブラリ同梱#234
Open
SilverRusk wants to merge 1 commit into
Open
Conversation
- jQuery/jQuery UI/jQuery.Gantt/Moment.js/Moment Timezone/JsRender をCDN参照からthirdparties同梱に変更(バージョン据え置き) - jQuery UI / jQuery.Gantt のCSSを同梱。CSS参照画像はkintoneプラグインで相対パスが解決されず404になるためbase64(data URI)で埋め込み - manifest.json のCDN URLをthirdparties相対パスへ置換、version 2.2.5→2.2.6 Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
LGWAN 環境向けに、ガントチャートプラグイン(examples/ganttchart)の依存ライブラリ参照を外部 CDN から同梱(thirdparties/)へ統一し、CSS 参照画像も data URI 化して 404 を回避する変更です。
Changes:
- manifest.json の参照先を CDN URL から
thirdparties/相対パスへ置換し、プラグイン version を 2.2.6 へ更新 - jQuery / jQuery.Gantt / Moment.js / JsRender 等の同梱ファイルを追加
- jQuery.Gantt の CSS を同梱し、画像参照を data URI で埋め込み
Reviewed changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/ganttchart/thirdparties/moment.min.js | Moment.js を同梱(ただし sourcemap 指定とライセンス表記に要対応) |
| examples/ganttchart/thirdparties/jsrender.min.js | JsRender を同梱(sourcemap 指定に要対応) |
| examples/ganttchart/thirdparties/jquerygantt/style.css | jQuery.Gantt の CSS 同梱(画像を data URI 化) |
| examples/ganttchart/thirdparties/jquery.min.js | jQuery を同梱 |
| examples/ganttchart/thirdparties/jquery.fn.gantt.min.js | jQuery.Gantt 本体を同梱 |
| examples/ganttchart/manifest.json | 読み込み先を thirdparties へ置換、version 更新 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ガントチャートプラグイン(ganttchart)の外部 CDN 参照を、LGWAN 環境対応のため全て同梱(thirdparties/)方式へ統一しました。ライブラリのバージョンは変更していません。
変更内容
動作確認