Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kylemcd
requested review from
BenaventeX24 and
thomaswhyyou
and removed request for
a team
July 14, 2026 14:38
🦋 Changeset detectedLatest commit: 703d5bf The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 11.97kB (2.13%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @knocklabs/react-core-react-core-cjsAssets Changed:
view changes for bundle: @knocklabs/react-react-cjsAssets Changed:
view changes for bundle: @knocklabs/expo-expo-cjsAssets Changed:
view changes for bundle: @knocklabs/client-client-cjsAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
view changes for bundle: @knocklabs/react-react-esmAssets Changed:
view changes for bundle: @knocklabs/react-core-react-core-esmAssets Changed:
view changes for bundle: @knocklabs/client-client-esmAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
view changes for bundle: @knocklabs/expo-expo-esmAssets Changed:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4d300f3. Configure here.
The auto-register effect gated on isAuthenticated but not the signed-in userId. Switching users on the same KnockProvider re-auths the same Knock instance (isAuthenticated never flips), so the effect never re-ran and the device token stayed bound to the previous user's channel data. Add userId to the effect deps so a switch re-registers for the new user. Mirrors the Slack/Teams authCheck-on-user-switch fix already in this release. Addresses the Cursor BugBot finding on #1038 (KNO-14229).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 64.71% 66.02% +1.31%
==========================================
Files 212 213 +1
Lines 10275 10500 +225
Branches 1406 1509 +103
==========================================
+ Hits 6649 6933 +284
+ Misses 3601 3542 -59
Partials 25 25
|
cjbell
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the
enabled-prop RC to a stable releaseThis merges the
rcrelease train intomainto cut the stable release of theKnockProviderenabledprop work (originally #1033 / KNO-14095), after it was validated on thercdist-tag.What ships (stable,
latesttag)@knocklabs/client@knocklabs/react@knocklabs/react-core@knocklabs/react-native@knocklabs/expoWhat merging this does
release.ymlruns on the push tomain, detects the branch is still in Changesets pre mode (.changeset/pre.jsonpresent), and auto-exits: it runschangeset pre exit+changeset version(collapsing the-rc.0versions to their stable equivalents), commits the exit, and pushes. That follow-up push publishes the packages above to thelatestnpm tag.After merge
latest.rcbranch (temporary per RELEASES.md).enabledprop).